nesting files in subdir for getNewTempFile #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it even need to be an option? Or, at least, having it on by default doesn't seem like it could hurt, right? |
|
we could make it the default. guess it was a style choice as paths read funny like |
|
updated default behavior |
viega
approved these changes
Nov 3, 2023
|
it was visually a bit annoying but I think simplicity of usage is more important. otherwise the caller needs to know some specifics about temp files vs rather just "give me temp file". those paths are not meant to be human readable anyhow so its prolly fine |
miki725
changed the title
|
That was exactly why it was my preference, good show :)
…On Fri, Nov 3, 2023 at 10:42 AM Miroslav Shubernetskiy < ***@***.***> wrote:
it was visually a bit annoying but I think simplicity of usage is more
important. otherwise the caller needs to know some specifics about temp
files vs rather just "give me temp file". those paths are not meant to be
human readable anyhow so its prolly fine
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABELGQPDOLBKSVPNJGEFKQTYCT7F5AVCNFSM6AAAAAA64NEIWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGU3TAMJQGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps such as
dockerwhen installed viasnapdont have permissions to access temporary files created directly in/tmpbut crucially can access them when nested inside another folder inside/tmp.This changes
getNewTempFile()function to create temporary file inside a nested directory inside the temp location whatever that might be as determined bygenTempPathwhich will honor things likeTMPDIR/etcThis resolves docker permission issues but still leaves tmp location to be default as determined by the OS/user
@indecisivedragon was able to test it on her Ubuntu linux instance which has docker installed with snap